Enable layout debugging for impl Trait type aliases
#70815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ r? @jonas-schievink |
|
📌 Commit 8f6c109 has been approved by |
bors
added
S-waiting-on-bors
eddyb
reviewed
Apr 5, 2020
Comment on lines
-87
to
+88
| &format!("layout debugging: {:#?}", *ty_layout), | ||
| &format!("layout debugging for type {:?}: {:#?}", ty, *ty_layout), |
There was a problem hiding this comment.
Wondering if maybe this should be "layout for type" without "debugging".
Or "layout_of({}) = {:#?}" :P.
There was a problem hiding this comment.
(but this PR is rolled up so this is for another time)
There was a problem hiding this comment.
Would be good to have some backticks if not that.
|
@RalfJung is there an issue for moving some/all |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#67797 (Query-ify Instance::resolve) - rust-lang#70777 (Don't import integer and float modules, use assoc consts) - rust-lang#70795 (Keep track of position when deleting from a BTreeMap) - rust-lang#70812 (Do not use "nil" to refer to `()`) - rust-lang#70815 (Enable layout debugging for `impl Trait` type aliases) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also made it print the actual type name that the alias picks under the hood.